Skip to content

KDE-Thumbnailers: Cleanup $WORK data after build #13944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2025
Merged

KDE-Thumbnailers: Cleanup $WORK data after build #13944

merged 1 commit into from
Sep 6, 2025
+3 −0

Conversation

amazingakai
Copy link
Contributor

The build fails at the check_build step due to running out of storage.
This change cleans up $WORK after the build to free up space.

https://oss-fuzz-build-logs.storage.googleapis.com/log-150d58fe-14f9-41cc-ac9c-1ae491fe4556.txt

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2025

amazingakai has previously contributed to projects/kde-thumbnailers. The previous PR was #13490

@tsdgeos
Copy link
Contributor

tsdgeos commented Sep 6, 2025

Is this really needed? Seems like it should be done by default?

@DavidKorczynski

@DavidKorczynski DavidKorczynski merged commit efff744 into google:master Sep 6, 2025
16 checks passed
@DavidKorczynski
Copy link
Collaborator

Is this really needed? Seems like it should be done by default?

@DavidKorczynski

hmm, I'm not entirely sure. Let's see if this fixes it in case. Otherwise, it would have to be an issues at runtime -- do any of the harnesses for some reason dump/log a lot to disk?

@amazingakai
Copy link
Contributor Author

amazingakai commented Sep 18, 2025 •
edited
Loading

Is this really needed? Seems like it should be done by default?
@DavidKorczynski

hmm, I'm not entirely sure. Let's see if this fixes it in case. Otherwise, it would have to be an issues at runtime -- do any of the harnesses for some reason dump/log a lot to disk?

The build is still failing: https://oss-fuzz-build-logs.storage.googleapis.com/log-4433fb3a-d637-44ae-b430-2fcfb05943fc.txt

Only the build-check-centipede-* fails with storage error, the previous two (afl and libFuzzer) checks pass successfully.

I checked some of the fuzzers, they don't do anything writing to disk except for writing to a temporary file which gets autodeleted when the process exits.

Should we maybe try disabling centipede build?

@amazingakai
Copy link
Contributor Author

@DavidKorczynski @tsdgeos ping

@tsdgeos
Copy link
Contributor

tsdgeos commented Sep 22, 2025

I checked some of the fuzzers, they don't do anything writing to disk except for writing to a temporary file which gets autodeleted when the process exits.

What if the process runs for hours, does that make the temporary files grow and grow?

@amazingakai
Copy link
Contributor Author

I checked some of the fuzzers, they don't do anything writing to disk except for writing to a temporary file which gets autodeleted when the process exits.

What if the process runs for hours, does that make the temporary files grow and grow?

No, the temporary files get autodeleted so they shouldn't grow.

@DavidKorczynski
Copy link
Collaborator

I'll try and debug this tonight

@DavidKorczynski
Copy link
Collaborator

I still need some more time to fully debug this, but I think I have a solution.

In the OSS-Fuzz build logs all the harnesses are failing before the disk exhaustion occurs. However, this is only for the centipede engine (see centipede in the build logs).

Locally, however, with the libfuzzer engine all but 1 harness pass:

INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/ebookthumbnail_fuzzer                                                                                                                        
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/comicbookthumbnail_fuzzer                                                                                                                    
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/pothumbnail_fuzzer                                                                                                                           
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/rawthumbnail_fuzzer                                                                                                                          
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/jpegthumbnail_fuzzer                                                                                                                         
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/cursorthumbnail_fuzzer                                                                                                                       
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/exrthumbnail_fuzzer                                                                                                                          
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/djvuthumbnail_fuzzer                                                                                                                         
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/blenderthumbnail_fuzzer                                                                                                                      
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/opendocumentthumbnail_fuzzer                                                                                                                 
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/windowsexethumbnail_fuzzer                                                                                                                   
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/imagethumbnail_fuzzer                                                                                                                        
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/windowsimagethumbnail_fuzzer                                                                                                                 
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/textthumbnail_fuzzer                                                                                                                         
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/kraorathumbnail_fuzzer                                                                                                                       
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/svgthumbnail_fuzzer                                                                                                                          
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/audiothumbnail_fuzzer                                                                                                                        
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/gsthumbnail_fuzzer                                                                                                                           
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/ffmpegthumbs_fuzzer                                                                                                                          
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/mobithumbnail_fuzzer                                                                                                                         
Retrying failed fuzz targets sequentially 1                                                                                                                                                                 
INFO: performing bad build checks for /tmp/not-out/tmpnxgt3itx/pothumbnail_fuzzer                                                                                                                           
Broken fuzz targets 1

The 1 breaking harness fails because of a leak.

As such, to fix this, I suggest (1) fix/silence the leak; (2) disable centipede for now.

I was running some testing with centipede but am atm on a small machine and the linking crashed OOMed my memory and building took a while to compile, so will have to pick this up tomorrow. But I assume that also signals for centipede there's some odd stuff happening which blows up the size of the harnesses. However, I'm quite sure the above two steps (double check other engines fwiw) will make build green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKorczynski DavidKorczynski DavidKorczynski approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amazingakai @tsdgeos @DavidKorczynski